actions/node-versions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 509 Wiki Activity

[versions-manifest] Update for release from 10/25/2023 #156

Merged
github-actions[bot] merged 1 commits from update-versions-manifest-file into main 2023-10-25 17:25:01 +05:00
Conversation 4 Commits 1 Files Changed 1
+39
github-actions[bot] commented 2023-10-25 09:46:40 +05:00 (Migrated from github.com)
Copy Link
Copy Source

Update versions-manifest.json for release from 10/25/2023

Update versions-manifest.json for release from 10/25/2023
MaksimZhukov (Migrated from github.com) approved these changes 2023-10-25 17:09:50 +05:00
dmitry-shibanov (Migrated from github.com) approved these changes 2023-10-25 17:24:53 +05:00
panva commented 2023-10-26 14:53:04 +05:00 (Migrated from github.com)
Copy Link
Copy Source

@MaksimZhukov @dmitry-shibanov this has incorrectly added Iron as lts codename to all 18.x releases prior to the actual first lts/iron which is the one added in this PR (18.9.0).

This is also the case for all not-yet-LTS versions of even-numbered releases.

@MaksimZhukov @dmitry-shibanov this has incorrectly added Iron as lts codename to all 18.x releases prior to the actual first lts/iron which is the one added in this PR (18.9.0). This is also the case for all not-yet-LTS versions of even-numbered releases.
panva commented 2023-10-26 14:57:24 +05:00 (Migrated from github.com)
Copy Link
Copy Source

I believe https://nodejs.org/download/release/index.json would be a better source of lts/non-lts for individual releases rather than https://raw.githubusercontent.com/nodejs/Release/main/schedule.json used in ./config/node-manifest-config.json

I believe https://nodejs.org/download/release/index.json would be a better source of lts/non-lts for individual releases rather than https://raw.githubusercontent.com/nodejs/Release/main/schedule.json used in [./config/node-manifest-config.json](https://github.com/actions/node-versions/blob/main/config/node-manifest-config.json)
Sign in to join this conversation.
Reviewers
No Reviewers
MaksimZhukov
dmitry-shibanov
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
shaman
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: actions/node-versions#156