actions/node-versions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 509 Wiki Activity

Add ability to trigger packages generation on PRs #43

Merged
MaksimZhukov merged 1 commits from v-mazhuk/add-pull-request-event-trigger into main 2020-11-03 17:14:49 +05:00
Conversation 7 Commits 1 Files Changed 1
+14 -7
MaksimZhukov commented 2020-11-02 18:10:25 +05:00 (Migrated from github.com)
Copy Link
Copy Source

Description
We've added logic to run the build-node-packages.yml workflow when the pull_request event occurs.

Details:

  1. By default, a workflow only runs when a pull_request's activity type is opened, synchronize, or reopened.
  2. We've hardcoded the 14.0.0 version of Node.js for workflow runs on pull_request event.
  3. New release will not be published if event is pull_request.
  4. The workflow run associated with the pull_request event will be added as a PR check:

image

We have also updated version of the setup-node action from v2.1.1 to v2.1.2.

**Description** We've added logic to run the `build-node-packages.yml` workflow when the `pull_request` event occurs. **Details:** 1) By default, a workflow only runs when a pull_request's activity type is `opened`, `synchronize`, or `reopened`. 2) We've hardcoded the `14.0.0` version of Node.js for workflow runs on `pull_request` event. 3) New release will not be published if event is `pull_request`. 4) The workflow run associated with the `pull_request` event will be added as a PR check: ![image](https://user-images.githubusercontent.com/46996400/97871348-6c208c80-1d25-11eb-8e2d-51915318154d.png) We have also updated version of the `setup-node` action from `v2.1.1` to `v2.1.2`.
vsafonkin (Migrated from github.com) reviewed 2020-11-02 18:10:25 +05:00
nikita-bykov (Migrated from github.com) reviewed 2020-11-02 18:10:25 +05:00
maxim-lobanov (Migrated from github.com) approved these changes 2020-11-02 18:11:36 +05:00
AlenaSviridenko (Migrated from github.com) approved these changes 2020-11-02 18:46:19 +05:00
maxim-lobanov (Migrated from github.com) approved these changes 2020-11-02 20:29:22 +05:00
al-cheb (Migrated from github.com) approved these changes 2020-11-02 22:23:05 +05:00
dmitry-shibanov (Migrated from github.com) approved these changes 2020-11-03 12:38:42 +05:00
Sign in to join this conversation.
Reviewers
No Reviewers
vsafonkin
nikita-bykov
AlenaSviridenko
maxim-lobanov
al-cheb
dmitry-shibanov
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
shaman
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: actions/node-versions#43